fix: has_events_marked to check actual bits, not just key existence
#80
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
My understanding of the problem:
has_events_markedwas checking for key existence only (I've changed to actually check the values within).select2is using a BitOp (ref ⬇️), and these operations create keys even when no bits are set.bitmapist/bitmapist/cohort/__init__.py
Lines 301 to 309 in 33aeeb1
Reference