Skip to content

Conversation

@chiara-doist
Copy link
Contributor

Description

My understanding of the problem:

  • has_events_marked was checking for key existence only (I've changed to actually check the values within).
  • This is because select2 is using a BitOp (ref ⬇️), and these operations create keys even when no bits are set.

# events for select2 (+select2b)
select2_events = fn_get_events(select2, delta_now, system)
if select2b:
select2b_events = fn_get_events(select2b, delta_now, system)
select2_events = BitOpAnd(system, select2_events, select2b_events)
if not select2_events.has_events_marked():
result.append("")
continue

Reference

@lefcha lefcha self-requested a review October 10, 2025 12:48
Copy link

@lefcha lefcha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@lefcha lefcha requested a review from amix October 10, 2025 12:55
@jacobo-doist
Copy link
Contributor

Whoa, brilliant, I threw Claude at this aggressively and ended up getting misdirected every time. Great find!

@chiara-doist chiara-doist changed the title fix:has_events_marked to check actual bits, not just key existence fix: has_events_marked to check actual bits, not just key existence Oct 10, 2025
Copy link
Member

@amix amix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat fix 👌 I also love that you added test cases

@chiara-doist chiara-doist merged commit 2f24f52 into main Oct 13, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants