Allow filtering types by attribute present#19
Merged
Dreamescaper merged 1 commit intomainfrom Mar 21, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for filtering types by checking for the presence of a specified attribute.
- Introduces a new WithAttribute property in the attribute and updates its documentation.
- Updates the dependency injection generator to include filtering logic based on WithAttribute.
- Adds tests to validate the new filtering behavior.
Reviewed Changes
Copilot reviewed 5 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| ServiceScan.SourceGenerator.Tests/AddServicesTests.cs | Added tests for filtering services by attribute and with type name filter. |
| ServiceScan.SourceGenerator/GenerateAttributeSource.cs | Added WithAttribute property along with its XML documentation. |
| ServiceScan.SourceGenerator/DependencyInjectionGenerator.FilterTypes.cs | Updated filtering logic to account for WithAttribute in type selection. |
| ServiceScan.SourceGenerator/Model/AttributeModel.cs | Updated model to include WithAttributeTypeName and adjust search criteria. |
| README.md | Updated documentation to reflect the new WithAttribute filtering option. |
Files not reviewed (2)
- ServiceScan.SourceGenerator.Tests/ServiceScan.SourceGenerator.Tests.csproj: Language not supported
- version.json: Language not supported
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #18 .