Allow multiple CustomHandler attributes on the same method#29
Merged
Dreamescaper merged 2 commits intomainfrom May 19, 2025
Merged
Allow multiple CustomHandler attributes on the same method#29Dreamescaper merged 2 commits intomainfrom
Dreamescaper merged 2 commits intomainfrom
Conversation
Owner
Author
|
Related to #28 . |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enables the use of multiple CustomHandler attributes on a method by updating diagnostic messages, modifying the condition for detecting mixed usages, and adding new tests.
- Updated diagnostic descriptors with clearer error messages.
- Adjusted conditional logic in the dependency injection generator to check for improper attribute combinations.
- Added comprehensive tests for scenarios with multiple CustomHandler attributes.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| ServiceScan.SourceGenerator/DiagnosticDescriptors.cs | Updated error messages to better describe the mixed usage of GenerateServiceRegistrations attributes. |
| ServiceScan.SourceGenerator/DependencyInjectionGenerator.ParseMethodModel.cs | Modified the condition that triggers the mixed attribute error diagnostic. |
| ServiceScan.SourceGenerator.Tests/CustomHandlerTests.cs | Added new tests to validate behavior when applying multiple CustomHandler attributes. |
ServiceScan.SourceGenerator/DependencyInjectionGenerator.ParseMethodModel.cs
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.