Open
Conversation
Owner
|
Hello Rahul, I like the ideas behind the changes, however, I think our vision over the overall look of the application are quite different. I also want to mention, promotion of external tools are strictly prohibited, unless you have used something that needs to be credited here. Can you also name the commits with some more information, and perhaps open pull requests (with titles) that are slightly more formal. Thanks for showing interest in this project, and spending time on making meaningful changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
was watching a Git tutorial and did some hands-on stuff using your repository
no pressure to pull these changes
no offense tho
lots of love,
rks