New yaw to cv object #106
Draft
New yaw to cv object #106
+154
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
converted to draft for organizational purposes on board (i.e., hasn't been tested yet) |
Contributor
|
@drago314 pls lint 🙏🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch is ready for a pool test. I assume it won't work not just because I have buggy code, but also we likely need different PID constants for this style of control. If this proves to be the case we can tune the PID to this function in the pool test, write the values down, and then figure out how to use different PID constants for diff control loops later.
Note that using diff PID constants for different types of control is a common control pattern.