REVIT-244971 - POC for analyzer to issue warnings for Dynamo custom attribute NodeObsolete #3265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add analyzer to detect usage of nodes (functions) marked with NodeObsolete from Dynamo Core.
* add analyzer to detect usage of nodes (functions) marked with NodeObsolete from Dynamo Core.
…e' of https://github.com/DynamoDS/DynamoRevit into cataliv/REVIT-244971/add_analyzer_for_NodeObsolete_usage
Mikhinja
requested review from
AdrianaStanica,
jasonstratton,
odragos,
vpavel04 and
zeusongit
Mikhinja
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NodeObsoletefrom Dynamo Core. Using a function marked with this attribute does not automatically issue a warning, so we need a mechanism to detect this and warn us when our code is using such a function, to proactively change it before it gets removed.Purpose
Add a custom analyzer to detect internal usage of nodes marked with
[NodeObsolete].Follow-up on Dynamo #16709.
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@zeusongit if there already is an analyzer or something similar for this purpose, please let us know how to use it.
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of