Merged
Conversation
EZoni
approved these changes
Nov 20, 2024
Member
EZoni
left a comment
There was a problem hiding this comment.
Looks good to me, all CI checks seem successful, so it's probably ready to merge. I left only two minor notes related to inline comments that might have been copied from WarpX.
Co-authored-by: Edoardo Zoni <59625522+EZoni@users.noreply.github.com>
lucafedeli88
commented
Nov 22, 2024
Member
|
Restarting CI because of old PR. |
Member
|
@lucafedeli88 let me know if you like to tag a new |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a new CI test that runs
clang-tidyon all the tests and demos ofpicsar_qed.Included/excluded
clang-tidychecks as well as check options can be found in.clang-tidy. For the moment, this configuration file is identical to what is used in WarpX.The PR also fixes all the issues found with the new
clang-tidyCI test. In order to fix some issues properly, now C++17 is used (up until now the library used C++14)