Fixed, PHP Warning: Invalid argument supplied for foreach(), cast array

[asig2016]

Error message during setup:

2019/03/05 22:12:42 [error] 1276#1276: *36 FastCGI sent in stderr: "PHP message: PHP Warning: Invalid argument supplied for foreach() in /home/asig/dev/egw/egwdev2/html/egw/filemanager/inc/class.filemanager_hooks.inc.php on line 237
PHP message: #1 /home/asig/dev/egw/egwdev2/html/egw/api/src/loader/deprecated_factory.php(179): filemanager_hooks::settings(Array)
PHP message: #2 /home/asig/dev/egw/egwdev2/html/egw/setup/inc/class.setup.inc.php(719): ExecMethod('filemanager_hoo...', Array)
PHP message: #3 /home/asig/dev/egw/egwdev2/html/egw/setup/inc/class.setup_process.inc.php(463): setup->set_default_preferences('filemanager')
PHP message: #4 /home/asig/dev/egw/egwdev2/html/egw/setup/inc/class.setup_process.inc.php(147): setup_process->current(Array, NULL)
PHP message: #5 /home/asig/dev/egw/egwdev2/html/egw/setup/index.php(349): setup_process->pass(Array, 'new', NULL, NULL)
PHP message: #6 {main}

[asig2016]

I thought there was a simpler solution that's why I closed the PR temporary.

[ralfbecker]

Hi Alexandros,

I have not merged this for 2 reasons:
a) coding standards: brackets should be on the next line
b) having an if clause around every foreach does not improve readability, so in case of a not set parameter, like this one, I prefer the following code:
foreach ((array)$editorLink['mime'] as $mime => $value)
That casts a not set attribute like 'mime' here to an empty array.
Of cause that only works for not set, not for things like false!

Please change your pull request to a cast.

Keep up the good work :)

Ralf

[ralfbecker]

Thanks :)