Skip to content

Fix building DX12 on windows #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
EIREXE merged 1 commit into from
Feb 13, 2026
Merged

Fix building DX12 on windows #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/workflows/windows_builds.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,12 @@ jobs:
run: |
./get_deps.ps1

- name: Download DX12 deps
run: |
cd engine
python misc\scripts\install_d3d12_sdk_windows.py
cd ..

- name: Compilation
uses: ./.github/actions/godot-build
with:
Expand Down
4 changes: 0 additions & 4 deletions modules/hbnative/thirdparty/tiny_process_lib/process_win.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
#include "core/string/print_string.h"
#include "process.hpp"
// clang-format off
#include <windows.h>
Expand Down Expand Up @@ -342,9 +341,6 @@ void Process::close_fds() noexcept {
}

bool Process::write(const char *bytes, size_t n) {
if(!open_stdin)
print_line("COCK");

std::lock_guard<std::mutex> lock(stdin_mutex);
if(stdin_fd) {
DWORD written;
Expand Down
Loading