-
Notifications
You must be signed in to change notification settings - Fork 61
Update from cmip6 to cmip7 co2 stream file #375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
I would like a preliminary review of this PR before I
@ekluzek would you like to look at this or recommend another reviewer? Only 5 lines have changed. |
| </stream_meshfile> | ||
| <stream_datafiles> | ||
| <file>$DIN_LOC_ROOT/atm/datm7/CO2/fco2_datm_global_simyr_1750-2014_CMIP6_c180929.nc</file> | ||
| <file>$DIN_LOC_ROOT/atm/datm7/CO2/co2_input4MIPs_GHGConcentrations_CMIP_CR-CMIP-1-0-0_gm_1750-2022.nc</file> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suspect that we will rename the new file. I did not wish to do so until I had confirmation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should retain the old dataset, so we can more easily compare and make sure the new dataset is correct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new file does need a creation date on it.and it needs to say CMIP7.
And actually the dataset above has all the greenhouse gases on it. In the past we just lifted out CO2 for the CDEPS streams. That might be worth doing, so it's clear those other fields aren't used. But, it also allows them to be added in easier in the future in case there might be a scientific need for it.
CDEPS issues:
Resolves #352
Resolves #361
Are there dependencies on other component PRs (if so list):
CTSM issue ESCOMP/CTSM#3386
CTSM PR to update .gitmodules with this PR's changes: TODO
Are changes expected to change answers (bfb, different to roundoff, more substantial):
Yes, more than roundoff, because the cmip7 co2 dataset differs from its cmip6 counterpart.
Any User Interface Changes (namelist or namelist defaults changes):
The new dataset spans 1750-2022 instead of 1750-2014.
Testing performed (e.g. aux_cdeps, CESM prealpha, etc):
So far, I completed 1-day simulations in
and the PCO2 output looks
/glade/derecho/scratch/slevis/archive/IHistClm6BgcCropCrujra_f09_ctsm5.4.003/cmip6co2Hashes used for testing:
1-day baseline: ctsm5.4.003
1-day experiment: ctsm5.4.003 with co2 stream changes in user_nl_datm_streams
1-day experiment: ctsm5.4.005 with cdeps1.0.84-1-g5a06fe0 (this PR)