Open
Conversation
…eb page to reflect what I am seeing. Had to comment out if (hasError) block as it is always failing and also needs a new selector.
Contributor
|
Hi @dabest1. Thanks for contributing. We're not seeing the same behavior on our side. It's possible that the new selector you propose is more universal. However, I'm uncomfortable with commenting out the error handling. Can you amend this PR to include working error handling? |
Author
|
I will try to add some error handling. But the original selectors being used by your code are not available for me for some reason. Should it just be a separate branch for people who see the same problem as me? |
…ew problem, where intermediate SAML page cannot be read. Had to remove error checking for Push step and create a function, which checks for desired selector in a loop. The loop required adding sleep module. Improved performance by changing Nightmare .type to .insert.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated Nightmare interactions with the web page to reflect what I am seeing. Had to comment out if (hasError) block as it is always failing and also needs a new selector.