Updated to the latest AWS SDK (v3), fixed a race conditIon with Okta.#35
Open
hoppersoft wants to merge 6 commits intoEarnest-Labs:masterfrom
Open
Updated to the latest AWS SDK (v3), fixed a race conditIon with Okta.#35hoppersoft wants to merge 6 commits intoEarnest-Labs:masterfrom
hoppersoft wants to merge 6 commits intoEarnest-Labs:masterfrom
Conversation
…unts with the same role name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(src/index.js) Added durationSeconds argument to allow the user to specify a timeout
(src/providers/okta.js) Fixed a race condition with Okta where the password wasn't being submitted by adding a wait() like there is for username. Added the same for push verification for the same reason.
(src/providers/okta-mfa.js) Added a name property for debugging.
(package.json, src/token-getter.js) Fixed runtime warnings that the AWS SDK v2 was going into maintenance mode. Fixed "new Buffer()" being deprecated in favor of alloc. Added 'duration' argument, modified logic to detect multiple accounts having the same role name when only the role name is provided.
(Dockerfile) Updated base image to a more recent LTS version of node (v18)