fix(cpn): fix win64 build #6598
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Maybe reverting this will fix the Win64 build 
|
Member
Author
|
I wonder what the second commit could be :-P And no, not even close... this issue stems from upstream change by github as they are now using windows-server-2025, so 2022 is now the pinned version, and this is just experimenting with how to continue with 2025 at this point. It looks like NSIS still isn't being detected, hence why the target is not available. |
pfeerick
added
ci: skip-fw
ci: skip-cpn-linux
ci: skip-cpn-macos
ci/cd
This reverts commit fb60a42.
Currently this is Windows Server 2025
pfeerick
force-pushed
the
pfeerick/fix-win64
branch
from
39512c3 to
5332e4a
Compare
NSIS is deteced and used now, so why can't we copy the install package?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test to see if this is the reason win64 broke - I fully expect it to fail as this makes no sense - but the build system can tell me that itself. 🤣