Rewrite Primitives, Scene, Camera, PhotonEngine in C++#16
Merged
EdwardPalmer99 merged 20 commits intomasterfrom Mar 2, 2025
Merged
Rewrite Primitives, Scene, Camera, PhotonEngine in C++#16EdwardPalmer99 merged 20 commits intomasterfrom
EdwardPalmer99 merged 20 commits intomasterfrom
Conversation
added 20 commits
March 2, 2025 19:07
EdwardPalmer99
force-pushed
the
EdwardPalmer99/partial-migration-to-CPP
branch
from
70089e3 to
2e229c1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Primitives code has become very messy and clunky with the use of C "virtual" functions. It makes more sense to move this into C++. There is a lot of work still to be done. For instance, passing-in by reference, better memory management, etc.