Skip to content
This repository was archived by the owner on Jul 12, 2022. It is now read-only.

Frontend dashboard and meetings room integration#39

Open
nooreldeensalah wants to merge 24 commits intomainfrom
sveltekit
Open

Frontend dashboard and meetings room integration#39
nooreldeensalah wants to merge 24 commits intomainfrom
sveltekit

Conversation

@nooreldeensalah
Copy link

Written in SvelteKit,

@AbdulrhmnGhanem
Copy link
Contributor

AbdulrhmnGhanem commented Sep 11, 2021

  • A running meeting shouldn't be in the /. I would suggest /the-key-used-for-jitsi, you can do this by dynamic parameters.
  • After leaving a meeting, the room name gets inserted in the labels field 👇, is this intentional?

image

  • There's no link to navigate to the dashboard; I have to type the URL.

  • When accessing the dashboard it keeps logging me out.

    You must be authenticated to access the dashboard
    
  • The table flashes then this ☝️ message appears; in theory, the data should only get fetched if the user is authenticated. Though actually anybody can access our database then there's no need to put it behind an authentication wall.

@nooreldeensalah
Copy link
Author

nooreldeensalah commented Sep 11, 2021

  • A running meeting shouldn't be in the /. I would suggest /the-key-used-for-jitsi, you can do this by dynamic parameters.

Done, using the roomName which is a random uuid.

  • After leaving a meeting, the room name gets inserted in the labels field 👇, is this intentional?

image

These were the labels.
Not intentional, forgot to clear the labels binding when a meeting is left.
Fixed.

  • There's no link to navigate to the dashboard; I have to type the URL.

I had a custom navigation bar in __layout.svelte file, and it only had the login/logout button, I'll add a button for the dashboard as well, you will need to adjust the layout along with the styling in case you didn't like this one.

  • When accessing the dashboard it keeps logging me out.
    You must be authenticated to access the dashboard
    

Yes, I noticed this, not a "full logout" though, but it flashes this sentence before displaying the tables (in case of an authenticated user), I think it has to do with the stores values maybe be re-propagating on reload?, or maybe it's an issue with Auth0 (Not really sure).

This sentence no longer appears, but it takes time until the UI components adjust to the isAuthenticated store value, perhaps you should test it and see if the behavior is undesirable?

  • The table flashes then this ☝️ message appears; in theory, the data should only get fetched if the user is authenticated. Though actually anybody can access our database then there's no need to put it behind an authentication wall.

To view the data tables one must be authenticated, if a user isn't authenticated (They won't be able to perform CRUD operations, they will get 401/403 errors if they tried), should I remove the authentication wall and only display the CRUD buttons when the user viewing the tables is authenticated? (I changed it such that, unauthenticated users would be able to display the data, but no CRUD buttons would appear to them).

@nooreldeensalah
Copy link
Author

nooreldeensalah commented Sep 11, 2021

There's a bug in the dashboard modals, the gist of it, is that when you create a modal component (by clicking on Edit/Add) and then close it and navigate to another table, it will pop-up on the other table page (I tried using {#key} blocks) to destroy the component on URL change, doesn't seem to solve it.

Not sure how to fix this bug (I don't know if it's a bug in https://github.com/flekschas/svelte-simple-modal or some issue with my code).

NVM, fixed it, I had to reset the modal store on table destruction because no page refreshes were done.

@AbdulrhmnGhanem
Copy link
Contributor

OK, we need spinners while data is loading.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants