Skip to content

fix: makes RebuildProjectionSequentially_Job actually sequential and … #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mynkow merged 3 commits into from
Dec 10, 2024
Merged

fix: makes RebuildProjectionSequentially_Job actually sequential and … #345

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
32eb238
fix: makes RebuildProjectionSequentially_Job actually sequential and …
ethno2405 Dec 5, 2024
1a5ca79
fix: soft the events by revision and position
ethno2405 Dec 6, 2024
006efc0
Adds some comments
mynkow Dec 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
67 changes: 36 additions & 31 deletions src/Elders.Cronus/Projections/Rebuilding/RebuildProjectionSequentially_Job.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,43 +98,48 @@ protected override async Task<JobExecutionStatus> RunJobAsync(IClusterOperations
{
OnAggregateStreamLoadedAsync = async stream =>
{
// 1. It is important to check all EventHandlers if they are interested in specific events and do this FIRST.
List<AggregateEventRaw> rawEvents = [];
foreach (string eventTypeContract in projectionEventsContractIds)
{
var eventsData = stream.Commits
IEnumerable<AggregateEventRaw> interested = stream.Commits
.SelectMany(x => x.Events)
.Where(x => IsInterested(eventTypeContract, x.Data))
.Select(x => x.Data);
.Where(x => IsInterested(eventTypeContract, x.Data));

foreach (var eventRaw in eventsData)
// Do not try to optimize the GC using Enumerable.Concat because it does not solve the issue
rawEvents.AddRange(interested);
}

// 2. Then the result is sorted!
IEnumerable<AggregateEventRaw> rawEventsSorted = rawEvents.OrderBy(x => x.Revision).ThenBy(x => x.Position); // Do not try to optimize the sorting with SortedDictionary. It is not faster.
foreach (AggregateEventRaw eventRaw in rawEventsSorted)
{
var @event = serializer.DeserializeFromBytes<IEvent>(eventRaw.Data).Unwrap();
if (@event is null)
{
logger.LogError("Failed to deserialize event from data {data}.", eventRaw.Data);
return;
}

Task projectionStoreTask = projectionWriter.SaveAsync(projectionType, @event, version);
Task replayTask = eventSourcedProjection.ReplayEventAsync(@event);

try
{
await Task.WhenAll([projectionStoreTask, replayTask]).ConfigureAwait(false);
}
catch (Exception ex)
{
IEvent @event = serializer.DeserializeFromBytes<IEvent>(eventRaw);
@event = @event.Unwrap();
if (@event is null)
{
logger.LogError("Failed to deserialize event from data {data}.", eventRaw);
return;
}

Task projectionStoreTask = projectionWriter.SaveAsync(projectionType, @event, version);
Task replayTask = eventSourcedProjection.ReplayEventAsync(@event);

try
{
await Task.WhenAll([projectionStoreTask, replayTask]).ConfigureAwait(false);
}
catch (Exception ex)
{
if (projectionStoreTask.IsFaulted)
logger.LogError(ex, "Failed to persist event!");

if (replayTask.IsFaulted)
logger.LogError(ex, "Failed to replay event!");

continue;
}

progressTracker.TrackAndNotify(@event.GetType().GetContractId(), ct);
if (projectionStoreTask.IsFaulted)
logger.LogError(ex, "Failed to persist event!");

if (replayTask.IsFaulted)
logger.LogError(ex, "Failed to replay event!");

continue;
}

progressTracker.TrackAndNotify(@event.GetType().GetContractId(), ct);
}
},
NotifyProgressAsync = async options =>
Expand Down
Loading