Skips rebuild requests in case of missing tenant in the configuration#347
Merged
Skips rebuild requests in case of missing tenant in the configuration#347
Conversation
gshukov98
force-pushed
the
skip-rebuild-messages
branch
from
14750f6 to
cae5f2f
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR updates the ProjectionBuilder class to skip rebuild requests when the tenant from the request is not present in the configuration.
- Introduces IOptions dependency injection to retrieve tenant configuration.
- Adds a check in HandleAsync to log a warning and return early if the tenant is missing.
Comments suppressed due to low confidence (1)
src/Elders.Cronus/Projections/Versioning/Handlers/ProjectionBuilder.cs:76
- [nitpick] Consider using the '!' operator for clarity: rewrite to 'if (!tenants.Tenants.Contains(sagaTimeout.Tenant))' to improve readability.
if (tenants.Tenants.Contains(sagaTimeout.Tenant) == false)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.