fix DSE paddle mapping mistake and touchpad grid wrong calculation#187
Open
lVentus wants to merge 1 commit intoElectronicks:masterfrom
Open
fix DSE paddle mapping mistake and touchpad grid wrong calculation#187lVentus wants to merge 1 commit intoElectronicks:masterfrom
lVentus wants to merge 1 commit intoElectronicks:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a regression introduced in v3.6.0 where pressing a DualSense Edge right paddle and function button triggers both left and right inputs.
Cause: The JS_TYPE_DS case falls through to JS_TYPE_DS4 and maps the same SDL paddle buttons twice after the SDL mapping refactor.
Fix: Add a break after JS_TYPE_DS to prevent duplicate paddle mappings.