Separate count and fir_count and convert to dict#2
Open
DimaVartanian wants to merge 2 commits intoElmegaard:mainfrom
Open
Separate count and fir_count and convert to dict#2DimaVartanian wants to merge 2 commits intoElmegaard:mainfrom
DimaVartanian wants to merge 2 commits intoElmegaard:mainfrom
Conversation
1. Separate count and found in raid count for quest items to prevent overwriting in case an item has separate FiR and not FiR requirements. No items currently seem to have both a fir and non-fir requirement, but seems like this can't hurt rather than using a flag which can overwrite state. 2. Replace both lists with dictionaries. This removes the nested lookup loops when building the files and allows you to look up items in constant time.
Author
|
About the second commit: I noticed that some things on the wiki didn't have consistent casing, so it's pretty much a crapshoot. "antique teapot" is one example that isn't correct, so looking up the name based on how it actually appears in the game doesn't work. Casting to lower case seems safer since you can always do the same with what you're looking it up with. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for making this cool library! I'm messing around with RatScanner and saw this. Made 2 changes that seem like they should be all around improvements
Note: old pull request can be ignored. Ended up with some merge issues so just recreated.