logging: backend: implement directory caching in the log_backend_fs.c#52
Merged
vladimirkhusainov-emcraft merged 1 commit intoemcraft-v3.7.99-ncs1-branchfrom Sep 17, 2025
Merged
Conversation
ayurtsev
force-pushed
the
rt-1000-818
branch
from
5842dec to
512e490
Compare
vladimirkhusainov-emcraft
requested changes
Sep 16, 2025
vladimirkhusainov-emcraft
left a comment
vladimirkhusainov-emcraft
left a comment
There was a problem hiding this comment.
Overall:
- I am not sure all the logic that handles the corner cases is correct. Please double-check.
- Please double check we return the memory allocated by k_malloc in all scenarious
- Please fix the issues reported by the CI checker.
RT-1000-818: - Directory caching greatly improves log autorotation mechanism on slow devices. - Run clang-format on the file and fix formatting. Signed-off-by: Alexander Yurtsev <alex@emcraft.com>
ayurtsev
force-pushed
the
rt-1000-818
branch
from
512e490 to
4ee0232
Compare
vladimirkhusainov-emcraft
approved these changes
Sep 17, 2025
vladimirkhusainov-emcraft
merged commit cc63545
into
emcraft-v3.7.99-ncs1-branch
7 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RT-1000-818: