Skip to content

fixes #58 #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RolfVeinoeSorensen wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fixes #58 #59

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion projects/router/src/lib/configuration.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ export const INTERNAL_ROUTER_CONFIGURATION = new InjectionToken<InternalRouterCo
{
factory: () => {
const { disabled, enableLinkTracking } = inject(INTERNAL_MATOMO_CONFIGURATION);
const routerConfig = inject(MATOMO_ROUTER_CONFIGURATION, InjectFlags.Optional) || {};
const routerConfig = inject(MATOMO_ROUTER_CONFIGURATION, {optional: true}) || {};

return { ...DEFAULT_ROUTER_CONFIGURATION, ...routerConfig, enableLinkTracking, disabled };
},
Expand Down
8 changes: 4 additions & 4 deletions projects/router/src/lib/page-url-provider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ export const MATOMO_PAGE_URL_PROVIDER = new InjectionToken<PageUrlProvider>(
factory: () =>
new DefaultPageUrlProvider(
inject(INTERNAL_ROUTER_CONFIGURATION),
inject(APP_BASE_HREF, InjectFlags.Optional),
inject(APP_BASE_HREF, {optional: true}),
inject(PlatformLocation)
),
}
Expand All @@ -26,10 +26,10 @@ function trimTrailingSlash(str: string): string {

export class DefaultPageUrlProvider implements PageUrlProvider {
constructor(
@Optional()
@Inject(INTERNAL_ROUTER_CONFIGURATION)
// @Optional() @Inject(INTERNAL_ROUTER_CONFIGURATION)
private readonly config: InternalRouterConfiguration,
@Optional() @Inject(APP_BASE_HREF) private readonly baseHref: string | null,
// @Optional() @Inject(APP_BASE_HREF)
private readonly baseHref: string | null,
private readonly platformLocation: PlatformLocation
) {}

Expand Down