Upgrade dependencies: Base UI, Drizzle v1, better-auth improvements#38
Upgrade dependencies: Base UI, Drizzle v1, better-auth improvements#38
Conversation
|
Summary of ChangesHello @Enalmada, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on a significant technical refresh, upgrading core dependencies and migrating UI components to enhance maintainability, improve performance, and streamline the development workflow. Key updates include transitioning from Radix UI to Base UI for a more modern component architecture, upgrading Drizzle ORM to its latest beta with improved relation handling, and integrating TanStack Form for a more robust form management solution. These changes aim to modernize the codebase and align with current best practices in web development. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a significant set of dependency upgrades, most notably migrating the UI from Radix to Base UI and updating Drizzle ORM to v1. The changes are extensive and appear to be well-executed, with the new RADIX_MIGRATION.md file providing excellent context for the UI changes. The updates to better-auth to improve session handling and the refactoring for Drizzle's new query builder are also solid improvements. My main feedback is a potential regression in the theming of toast notifications, which I've detailed in a specific comment. Overall, this is a very impressive and thorough upgrade.
| return ( | ||
| <Sonner | ||
| theme={theme} | ||
| theme="system" |
There was a problem hiding this comment.
The theme for the Sonner component is now hardcoded to "system". This is a regression from the previous implementation which used useTheme from the now-removed next-themes package. If the application's ThemeToggle allows users to set a theme that differs from their system preference (e.g., forcing dark mode on a light system), the toasts will not match the application's theme. The theme prop should dynamically reflect the application's current theme to ensure visual consistency.
Summary
Major dependency upgrades and improvements:
better-auth/minimalfor smaller bundle size@better-auth/drizzle-adapterfrom PR #6913 for Drizzle v1 compatibilityKey Changes
relations.tsusingdefineRelationsbuildWhereClausefor Drizzle v1 RQBv2 object-based filtersKnown Limitations
experimental.joinsis disabled in better-auth config until the drizzle adapter PR fully supports Drizzle v1 RQBv2 relationsTest plan