Create a log of the grammar paths take an attach as metadata to top of result#184
Open
kanaka wants to merge 1 commit intoEngelberg:masterfrom
Open
Create a log of the grammar paths take an attach as metadata to top of result#184kanaka wants to merge 1 commit intoEngelberg:masterfrom
kanaka wants to merge 1 commit intoEngelberg:masterfrom
Conversation
When a Tramp record is created by make-tramp, the grammar tree is walked and the get-in style path is attached as metadata to each node in the grammar tree. Also a new :path-log atom is added to the Tramp record. In push-result (during parsing) the current path is retrieved from the metadata of node in the grammar tree being processed. The path is then added to the :path-log of the tramp object. When the final result is returned, the :path-log from the tramp object is added to the metadata of the top of the result returned.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This proposed change keeps track of all the paths take through the grammar during parsing. I'm using instaparse with this change to analyze a corpus of test cases and then use test.check to generate new tests cases that are probabilistically "similar" to the corpus. I use the path log to create a weight file for my test.check generators.
I don't necessarily consider this in final form but it's currently working for me so I'm creating this PR to get feedback/discussion.
I know that performance behavior of instaparse is critical. Do you have performance tests that I could use to test this change to characterize what impact if any it has on performance?