assignment 2, learning about redis#21
Open
baotyphu wants to merge 1 commit intoEngineerProOrg:scott/sample-gormfrom
Open
assignment 2, learning about redis#21baotyphu wants to merge 1 commit intoEngineerProOrg:scott/sample-gormfrom
baotyphu wants to merge 1 commit intoEngineerProOrg:scott/sample-gormfrom
Conversation
baotyphu
force-pushed
the
scott/sample-gorm
branch
from
eddc942 to
4945752
Compare
tpdongcs
reviewed
Jun 5, 2023
|
|
||
| func tryLockRedisForKey(key string, value string, expireTime time.Duration) { | ||
| for { | ||
| result := redisClient.SetNX(redisClient.Context(), key, value, expireTime) |
Collaborator
There was a problem hiding this comment.
should sleep for a while after a loop , if not then redis will send a lot of request when trying
| sleep(sleepTime) | ||
| // doSomething | ||
|
|
||
| if strings.Compare(redisClient.Get(c, key).Val(), newUUID) == 0 { |
Collaborator
There was a problem hiding this comment.
this one should be called in a defer after line 71, to make sure it will be called
| func rateLimiterHandler(c *gin.Context) { | ||
| username := c.Params.ByName("username") | ||
| redisClient.Incr(redisClient.Context(), username) | ||
| requestNumberOfUser, _ := redisClient.Get(redisClient.Context(), username).Int64() |
Collaborator
There was a problem hiding this comment.
the number should be from incr command instead, because if we call like this, the number can be wrong
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.