Skip to content

Snapshot improvement on Commanded 1.3.1 #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
juggy wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Snapshot improvement on Commanded 1.3.1 #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
659c1f6
Respect snapshot params when rebuilding aggregate from event stream
alexspeller Jul 9, 2021
069b361
Merge branch 'commanded-master' into snapshot-improvement-1-3-1
juggy May 4, 2022
890e16b
Tests
juggy May 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .tool-versions
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
elixir 1.13.3-otp-24
erlang 24.2
erlang 24.2.1
31 changes: 29 additions & 2 deletions lib/commanded/aggregates/aggregate_state_builder.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ defmodule Commanded.Aggregates.AggregateStateBuilder do
alias Commanded.EventStore.SnapshotData
alias Commanded.Snapshotting

require Logger

@read_event_batch_size 100

@doc """
Expand Down Expand Up @@ -64,10 +66,35 @@ defmodule Commanded.Aggregates.AggregateStateBuilder do
defp rebuild_from_event_stream(event_stream, %Aggregate{} = state) do
Enum.reduce(event_stream, state, fn event, state ->
%RecordedEvent{data: data, stream_version: stream_version} = event
%Aggregate{aggregate_module: aggregate_module, aggregate_state: aggregate_state} = state

%Aggregate{
state
aggregate_module: aggregate_module,
aggregate_state: aggregate_state,
aggregate_version: aggregate_version,
snapshotting: snapshotting
} = state

state_with_snapshot =
if snapshotting && Snapshotting.snapshot_required?(snapshotting, stream_version) do
case Snapshotting.take_snapshot(snapshotting, aggregate_version, aggregate_state) do
{:ok, snapshotting} ->
# nocommit
IO.puts("Stream version: #{stream_version}")
%Aggregate{state | snapshotting: snapshotting}

{:error, error} ->
Logger.warn(fn ->
"snapshot failed due to: " <> inspect(error)
end)

state
end
else
state
end

%Aggregate{
state_with_snapshot
| aggregate_version: stream_version,
aggregate_state: aggregate_module.apply(aggregate_state, data)
}
Expand Down