Refactor guided by tests#3

Open

sgharms wants to merge 60 commits intoEricaJoy:masterfrom

sgharms:refactor-guided-by-tests

Commits on Nov 21, 2014

Add Jasmine Standalone test framework
Steven G. Harms
committed
Add jQuery support
Steven G. Harms
committed
getBookmarks: Add guard clause if chrome.bookmarks DNE
Steven G. Harms
committed

Commits on Jan 6, 2015

Define noQuery.extend
Steven G. Harms
committed
Refactor: EXTRACT CLASS: Provide Bookmark class
Steven G. Harms
committed

Commits on Jan 7, 2015

urlTesting(): Reformat
Steven G. Harms
committed
urlTesting(): use jQuery.Deferred
Steven G. Harms
committed
urlTesting(): extract repeated template code
Steven G. Harms
committed
urlTesting(): Simplify
Steven G. Harms
committed
urlTesting(): Rename parameter from obj -> bookmark
Steven G. Harms
committed
urlTesting(): Refactor: SEPARATE MODIFICATION FROM QUERY
Steven G. Harms
committed
urlTesting(): Refactor: MOVE METHOD
Steven G. Harms
committed
Bookmark: Refactor: EXTRACT METHOD toHtml()
Steven G. Harms
committed
Bookmark#urlTesting: Use $.Deferred interface for updating DOM
Steven G. Harms
committed
Boookmark: Refactor: RENAME METHOD urlTesting -> determineHttpStatus
Steven G. Harms
committed
Bookmark: should determine its own HTTP status
Steven G. Harms
committed
Add Jasmine Ajax Mocking Support
Steven G. Harms
committed
Bookmark: Test AJAX logic for status
Steven G. Harms
committed

Commits on Jan 8, 2015

treeWalk(): Reformat
Steven G. Harms
committed
Empty out comments and debugging statements
Steven G. Harms
committed
treeWalk: Formatting: if/else
Steven G. Harms
committed
Whitespace
Steven G. Harms
committed
treeWalk(): Refactor: Replace loop with closure iterator
Steven G. Harms
committed
treeWalk(): Refactor: Replace loop with closure iterator
Steven G. Harms
committed
treeWalk: Refactor: Introduce Null Object: window.bookmarksArray
Steven G. Harms
committed

Commits on Jan 9, 2015

treeWalk(): Refactor: MOVE METHOD: Move into a View class
Steven G. Harms
committed
Container: Introduce class for handling recursive loading
Steven G. Harms
committed

Commits on Jan 10, 2015

Add tests for Container's container() methods
Steven G. Harms
committed
View#treeWalk(): Calculate container bar display from Container collection
Steven G. Harms
committed
View#treeWalk: extract HTML calculation to Container class
Steven G. Harms
committed
Add Container#bookmarks()
Steven G. Harms
committed
getBookmarks(): Reformat
Steven G. Harms
committed
getBookmarks(): Simplify internal structure
Steven G. Harms
committed
getBookmarks(): Refactor: INLINE METHOD
Steven G. Harms
committed
$(document).ready(): Reformat
Steven G. Harms
committed
View: Refactor: RENAME METHOD treeWalk -> draw
Steven G. Harms
committed
View: Refactor: EXTRACT METHOD _initializeSelectionControls
Steven G. Harms
committed
View: Refactor: EXTRACT METHOD
Steven G. Harms
committed
View._initializeSelectionControls: DRY it up
Steven G. Harms
committed
View._initializeDeletionControls: Reformat
Steven G. Harms
committed
Remove noQuery: let's use jQuery for now
Steven G. Harms
committed

Commits on Jan 11, 2015

Revert "Remove noQuery: let's use jQuery for now"
Steven G. Harms
committed
Remove jQuery: checkbox event binding
Steven G. Harms
committed
Remove jQuery: Remove jQuery UI dialog box
Steven G. Harms
committed
cleanup.html: rm trailing whitespace
Steven G. Harms
committed

Commits on Jan 12, 2015

Remove jQuery: Remove $.append() call
Steven G. Harms
committed
Remove unhelpful comment
Steven G. Harms
committed
Remove jQuery: Remove $(document).ready()
Steven G. Harms
committed

Commits on Jan 13, 2015

noQuery.get(): Introduce method
Steven G. Harms
committed
bookmarkcleanup_spec: rm tests that fail due to Promises
Steven G. Harms
committed
Container: ensure we don't build Bookmarks for scriptlets
Steven G. Harms
committed
Remove jQuery
Steven G. Harms
committed
Merge branch 'remove-jquery' into refactor-guided-by-tests
Steven G. Harms
committed
noQuery.checkboxes: shorten call to slice()
Steven G. Harms
committed

Commits on Jan 21, 2015

View._initializeSelectionControls: Make more terse
Steven G. Harms
committed
Merge branch 'visual-cleanup' into refactor-guided-by-tests
Steven G. Harms
committed
Remove tabs permission
Steven G. Harms
committed
Remove tabs callback: wasn't used
Steven G. Harms
committed
remove "content_security_policy"
Steven G. Harms
committed
Merge branch 'cleanup-chrome-extension' into refactor-guided-by-tests
Steven G. Harms
committed