fix: replace bare except with except Exception#107
Open
Jah-yee wants to merge 4 commits intoEverMind-AI:mainfrom
Open
fix: replace bare except with except Exception#107Jah-yee wants to merge 4 commits intoEverMind-AI:mainfrom
Jah-yee wants to merge 4 commits intoEverMind-AI:mainfrom
Conversation
- src/biz_layer/mem_db_operations.py line 146 - src/infra_layer/.../episodic_memory_milvus_repository.py line 127 Bare except catches BaseException including KeyboardInterrupt and SystemExit. Using except Exception preserves fallback behavior while allowing system exceptions to propagate. Fixes EverMind-AI#98
In simple_memory_manager.py search() method docstring, the "rrf" retrieval mode was listed twice. Removed the first occurrence as the second is more descriptive. Fixes EverMind-AI#97
The ./docker/mongodb/init:/docker-entrypoint-initdb.d volume mount in docker-compose.yaml references a directory that never existed. MongoDB initialization is handled at the application layer (Beanie ODM + migration manager), not via Docker init scripts. Fixes EverMind-AI#90
Issue EverMind-AI#48: Inconsistent timestamp formats in episodic memories Changes: - Updated EPISODE_GENERATION_PROMPT to enforce strict ISO 8601 format - Examples of correct format: 2026-01-23T02:19:25Z or 2026-01-23T10:07:00+08:00 - Explicitly prohibits Chinese characters, weekdays, and partial times This ensures consistent timestamp parsing, sorting, and filtering in downstream operations.
Jah-yee
added a commit
to Jah-yee/EverMemOS
that referenced
this pull request
Mar 3, 2026
…e docstring - Replace bare 'except:' with 'except Exception:' in: - src/biz_layer/mem_db_operations.py (line 146) - src/infra_layer/adapters/out/search/repository/episodic_memory_milvus_repository.py (line 127) - Enforce ISO 8601 timestamp format in episodic memory prompts: - Add strict format requirements: YYYY-MM-DDTHH:MM:SSZ or YYYY-MM-DDTHH:MM:SS+HH:MM - Update examples to use ISO 8601 format - Prevents inconsistent timestamp formats (Chinese chars, weekdays, AM/PM, UTC) - Remove duplicate 'rrf' entry in demo/utils/simple_memory_manager.py docstring Fixes EverMind-AI#107, EverMind-AI#97, EverMind-AI#108 (related to EverMind-AI#48)
Jah-yee
added a commit
to Jah-yee/EverMemOS
that referenced
this pull request
Mar 3, 2026
… issues - Fix EverMind-AI#50: Remove duplicate 'rrf' entry in demo docstring - Fix EverMind-AI#107: Replace bare except with except Exception in mem_db_operations.py - Fix EverMind-AI#107: Replace bare except with except Exception in episodic_memory_milvus_repository.py - Fix EverMind-AI#48: Add ISO 8601 timestamp format requirement to episode_mem_prompts.py All modified files pass Python syntax validation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace bare
except:withexcept Exception:in two files.Changes
src/biz_layer/mem_db_operations.pyline 146src/infra_layer/adapters/out/search/repository/episodic_memory_milvus_repository.pyline 127Why
Bare
except:catchesBaseExceptionincludingKeyboardInterruptandSystemExit. Usingexcept Exception:preserves fallback behavior while allowing system exceptions to propagate.Fixes #98