Enable forced retranslation on wiki updates #673
Conversation
|
|
Summary of ChangesHello @AshakaE, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the wiki update process by introducing forced retranslation for existing translated wikis. Previously, once a wiki was translated, subsequent updates to the original content would not automatically trigger a retranslation. This change ensures that translated versions in Korean and Chinese are kept up-to-date with the latest content modifications, improving consistency across languages. Additionally, it streamlines the codebase by removing an unused event capture mechanism. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request enables forced retranslation of wikis upon updates by introducing a retranslate flag. The changes look good and achieve the goal. I've pointed out a bug in logging where the language is hardcoded, which could lead to confusing logs. Additionally, with the removal of the captureEvent method, the posthogService has become an unused dependency and should be removed for better code maintainability.
| await this.revalidate.revalidatePage(wiki.id) | ||
| } | ||
| return true | ||
| } |
There was a problem hiding this comment.
With the removal of the captureEvent method, the posthogService is no longer used in this class. Please remove it from the class constructor and the corresponding import to keep the code clean and avoid injecting unused services.
| } as unknown as Activity), | ||
| ) | ||
|
|
||
| await this.captureEvent( |
There was a problem hiding this comment.
why remove all the posthog events?
There was a problem hiding this comment.
it doesn't capture any event, it did post initially
Added forced retranslation for wiki edits, initially once translated, the translated wikis remain the same except a forced retranslation occurs
Linked issues
closes https://github.com/EveripediaNetwork/issues/issues/4659