Bug fix in cfg settings #37
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bind_mesh function is hardcoding contract.roundtime=2000 (2 seconds) into the configuration incorrectly causing a duplicate roundtime setting in the default of 1000 irrespective of what contract.roundtime=2000 or what the hp.cfg.override is set to.
It should be setting this to contract.consensus.roundtime
```
cat /var/lib/docker/volumes/hpdevkit_default_vol/_data/node1/cfg/hp.cfg | grep -A10 -B5 roundtime
"bin_args": "index.js",
"environment": {},
"max_input_ledger_offset": 10,
"consensus": {
"mode": "public",
"roundtime": 1000, <--------
"stage_slice": 25,
"threshold": 80
},
"npl": {
"mode": "private"
},
"round_limits": {
"user_input_bytes": 0,
"user_output_bytes": 0,
"npl_output_bytes": 0,
"proc_cpu_seconds": 0,
"proc_mem_bytes": 0,
"proc_ofd_count": 0,
"exec_timeout": 300000
},
"roundtime": 2000 <-------
},
"mesh": {
"port": 22861,
"listen": true,
"idle_timeout": 120000,
"known_peers": [
"node2:22862",
"node3:22863"
],
"msg_forwarding": true,
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bind_mesh function is hardcoding contract.roundtime=2000 (2 seconds) into the configuration incorrectly causing a duplicate roundtime setting in the default cfg (currently set at 1000), irrespective of what contract.roundtime=2000, or what hp.cfg.override is set to.
It should be setting this to contract.consensus.roundtime.
Currently, setting roundtime in hp.cfg.override in hpdevkit has no effect on consensus roundtime and it perists at 1000ms.