Conversation
… publish outside of lock
alehuo
approved these changes
Feb 24, 2026
|
|
||
| status = resolve_job_status(total, success, failed) | ||
|
|
||
| # TODO: maybe buffer to avoid spamming |
Collaborator
There was a problem hiding this comment.
Good point. Perhaps the whole job progress could be split into ~1/50th pieces depending on how many papers there are. E.g. For 10 000 papers, we would publish progress every 200 papers.
Another one would be to have some kind of "throttling" queue. We would limit job progress events to ~1 per 5 seconds, and drop events that arrive before that time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task progress updated to use SSE.
/api/v1/job?project=[uuid]now also returnsJobStats.