Open
Conversation
Collaborator
saimouu
commented
Feb 19, 2026
saimouu
commented
- Change validation logic to allow empty abstracts
- Empty abstracts default to NO_ABSTRACT
- Empty asbtract count is returned on file upload
- Warning toast is displayed in front if empty abstracts were detected
- Change validation logic to allow empty abstracts - Empty abstracts default to NO_ABSTRACT - Empty asbtract count is returned on file upload - Warning toast if displayed in front if empty abstracts were detected
alehuo
requested changes
Feb 24, 2026
Collaborator
alehuo
left a comment
alehuo
left a comment
There was a problem hiding this comment.
Looks good to me. One minor comment
Comment on lines
1
to
66
| @@ -51,4 +63,4 @@ def validate_csv(file_obj: BinaryIO, filename: str) -> List[FileError]: | |||
| file_obj.seek(0) | |||
| except Exception: | |||
| pass | |||
| return errors | |||
| return errors, empty_abstract_count | |||
Collaborator
There was a problem hiding this comment.
Could this be done without the for loop? With large CSV files it can get slow quick. With about 10 000 rows a for loop can take ~3-4 seconds, vectorized operations take milliseconds.
I would do it like this:
mask = df["something"].isna()
count_of_something_na = mask.sum()
df.loc[mask, "something"] = NoneAlso - NaN vs None. I'm not sure which one is better in this case.
Collaborator
Author
There was a problem hiding this comment.
Yeah makes sense. I'll look into it.
The same df.iterrows() loop is done in process_files().
Could also try to remove the duplicate file reading, maybe just modifying validate_csv() to also return the data could make sense.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.