Bump Onyx to 2.0.122

[TMisiukiewicz]

Explanation of Change

Changelog:
Expensify/react-native-onyx#620
Expensify/react-native-onyx#655
Expensify/react-native-onyx#659
Expensify/react-native-onyx#657

Fixed Issues

$ #65715
PROPOSAL:

Tests

For Expensify/react-native-onyx#655: No tests needed as it is not yet used anywhere in the app

1. Go to FAB -> Create expense
2. Use image that is not a valid receipt
3. Submit the expense
4. Wait until the image is scanned and the error appeared
5. Go back to LHN
6. Verify the RBR is displayed next to the report

• Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as tests

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

android.native-compressed.mov

Android: mWeb Chrome

iOS: Native

ios.native-compressed.mov

iOS: mWeb Safari

ios.web-compressed.mov

MacOS: Chrome / Safari

chrome-compressed.mov

MacOS: Desktop

desktop-compressed.mov

[github-actions]

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

[melvin-bot]

@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[github-actions]

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

[TMisiukiewicz]

looking into failing test with @fabioh8010 , caused by Expensify/react-native-onyx#620

[parasharrajat]

@TMisiukiewicz I see that you are discussing some changes on Slack. Should I continue testing this PR or wait for those changes?

[TMisiukiewicz]

@parasharrajat please wait with testing - most likely we'll need to release new version of Onyx with improvements addressing the issues we have in this PR

[parasharrajat]

Sure

[github-actions]

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

[github-actions]

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #65811.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/65811/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/65811/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/65811/NewExpensify.dmg	https://65811.pr-testing.expensify.com

---

👀 View the workflow run that generated this build 👀

[TMisiukiewicz]

waiting for Expensify/react-native-onyx#657 to be merged and released to continue with a bump

[TMisiukiewicz]

Updated the branch with recently merged changes required to fix a couple of issues related to changes from 2.0.120

[github-actions]

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

[parasharrajat]

@TMisiukiewicz is this ready for review?

[parasharrajat]

I will start shortly...

[parasharrajat]

Continuing here...

[parasharrajat]

Android: I am noticing this bug where chat moves to chat report page which is no report. Clicking on the header takes to no_pagefound error page.

Steps: same as #55199

15.07.2025_20.01.19_REC.mp4

[parasharrajat]

But its kind of same on main the header is loading state.

[mountiny]

@parasharrajat can you prioritize this one please? thanks!

[parasharrajat]

There is this issue that posted above. It behaves differently then main. May we we can consider that as a separate issue. But I need a confirmation for that too.

[TMisiukiewicz]

Interesting, on iOS and Android, both on main and on this branch I end up with skeleton instead of the header:

I'm using Newdot build. Does everything work as expected for you on main @parasharrajat ?

[parasharrajat]

On main, I see skeleton loader same as you, but on the PR I was seeing Chat Report header which takes nowhere.

Technically, both of these behaviours are issues. So I wouldn't wait on those. We can target them later.

[parasharrajat]

@TMisiukiewicz Can you please merge main? There are test failures.

[TMisiukiewicz]

@parasharrajat oh I merged it already but forgot to push to remote 😄 Failing tests are most likely due to flakiness

[mountiny]

How is this one looking? @parasharrajat

[parasharrajat]

Just wrapping this up.

[parasharrajat]

I am going to tag this #65811 (comment) on the #55199, we should further pursue this flow to make sure we do this loading state.

There is some issue with data loading of the user, I think, after clearing the cache.

Steps:

1. Login with a new account.
2. Select "Track and budget expenses" during onboarding.
3. Create a tracked expense for yourself.
4. submit that expense to a user.
5. Create another tracked expense.
6. Clear cache and restart from troubleshoot page.
7. Go back to tracked expense and submit that to the same user as previously done.
8. Notice that on the participant page, the user information does not load properly.
9. Then after submitting that expense the chat goes into loading state.

[parasharrajat]

Screenshots

🔲 iOS / native

17.07.2025_16.58.32_REC.mp4

🔲 iOS / Safari

17.07.2025_17.02.00_REC.mp4

🔲 MacOS / Desktop

17.07.2025_17.13.57_REC.mp4

🔲 MacOS / Chrome

15.07.2025_19.51.27_REC.mp4

15.07.2025_19.47.43_REC.mp4

🔲 Android / Chrome

17.07.2025_17.06.32_REC.mp4

🔲 Android / native

17.07.2025_16.51.47_REC.mp4

[parasharrajat]

@TMisiukiewicz I would say that you remove the test steps for Expensify/react-native-onyx#620 as this PR does not solve that. We still have an issue, as mentioned above.

We don't want QA to create a regression issue for that. Do you agree?

[parasharrajat]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified tests pass on all platforms & I tested again on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

🎀 👀 🎀 C+ reviewed

[mountiny]

Thank you!

@TMisiukiewicz can you please list out the test steps numbered here and also make sure we can follow up on the bug that should be fixed but is not?

[TMisiukiewicz]

@mountiny

1. Log in with a new account.
2. Select "Track and budget expenses" during onboarding.
3. Enter a name to complete the onboarding
4. Go to the Self DM.
5. Track an expense
6. Submit it to any user
7. Go back to the self DM
8. Track another expense
9. Go to Settings > Troubleshoot.
10. Tap on "Clear cache and restart.
11. Go back to the inbox / self DM
12. Submit the expense to the same user

[mountiny]

Ok thank you!

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[github-actions]

🚀 Deployed to staging by https://github.com/mountiny in version: 9.1.84-1 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

[github-actions]

🚀 Deployed to production by https://github.com/cristipaval in version: 9.1.84-4 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅