fix: fix crash due data race on globalMarkdownWorkletRuntime#752
Open
linhvovan29546 wants to merge 2 commits intoExpensify:mainfrom
Open
fix: fix crash due data race on globalMarkdownWorkletRuntime#752linhvovan29546 wants to merge 2 commits intoExpensify:mainfrom
linhvovan29546 wants to merge 2 commits intoExpensify:mainfrom
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
tomekzaw
previously approved these changes
Feb 15, 2026
tomekzaw
reviewed
Feb 15, 2026
tomekzaw
approved these changes
Feb 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
This PR fixes the Sentry crash
(std::__ndk1::default_delete<T>::operator()[abi:ne180000])reported here. TheglobalMarkdownWorkletRuntimecould be accessed from both theJSandUIthreads, causing a data race, this PR adds a mutex to protect thisshared_ptr.Related Issues
Expensify/App#82146
Manual Tests
This issue is hard to reproduce, so please we need to verify that the input still works as before like typing, copy/pasting, and other basic interactions
Linked PRs