Upgrade eslint-config-expensify to report unused disable directives#743
Draft
roryabraham wants to merge 1 commit intomainfrom
Draft
Upgrade eslint-config-expensify to report unused disable directives#743roryabraham wants to merge 1 commit intomainfrom
roryabraham wants to merge 1 commit intomainfrom
Conversation
Upgrades to a version that sets reportUnusedDisableDirectives: 'error'. No unused directives were found in this repo. Made-with: Cursor
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Upgrades
eslint-config-expensifyto a version that includesreportUnusedDisableDirectives: 'error'in the base config. This ensures staleeslint-disablecomments that no longer suppress an active rule violation are flagged as errors.No unused directives were found in this repo, so the only change is the dependency upgrade.
Depends on Expensify/eslint-config-expensify#180
Related Issues
N/A - tooling improvement
Automated Tests
N/A - lint config change only
Manual Tests
npx eslint .and verify noUnused eslint-disable directiveerrors appearAuthor Checklist
### Related Issuessection aboveTestssectionScreenshots/Videos
N/A - no UI changes
Made with Cursor