task: web server v2 additional args #105
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Jan 2, 2026
Update load balancer SSL policy to `ELBSecurityPolicy-TLS13-1-2-2021-06` (enforces TLS 1.2+/TLS 1.3, modern ciphers, improved security and performance).
mandryllo
requested changes
Jan 12, 2026
| privateZone: false, | ||
| }); | ||
|
|
||
| const webServerWithDomain = new studion.WebServerBuilder(`web-server-domain`) |
Collaborator
There was a problem hiding this comment.
Suggested change
| const webServerWithDomain = new studion.WebServerBuilder(`web-server-domain`) | |
| const webServerWithCustomDomain = new studion.WebServerBuilder(`web-server-domain`) |
just because we use customDomain inside web server component 🤔
definitely if you decide to change the name then don't forget to update it on other places also
Member
Author
There was a problem hiding this comment.
I think withDomain is already self explanatory. I don't think we need to necessary map it to a method name...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes: