feat: DB v2 custom db tests #97
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mandryllo
force-pushed
the
feat/db-v2-tests
branch
from
04800c7 to
41783a5
Compare
# Conflicts: # tests/database/index.test.ts
mandryllo
force-pushed
the
feat/custom-db-v2-tests
branch
from
febb6cd to
6f9884f
Compare
bornast
requested changes
Jan 2, 2026
Comment on lines
3
to
4
| import { DatabaseBuilder } from '../../../dist/v2/components/database/builder'; | ||
| import * as config from './config'; |
Member
There was a problem hiding this comment.
This import will be resolved when you fix the base branch.
Member
There was a problem hiding this comment.
I feel like we are missing real integration tests here using Describe commands like we do in other tests. Also we are not actually testing if we can connect to the db like we do for example in upstash or elasticache tests.
| assert.ok(TagList && TagList.length > 0, 'Tags should exist'); | ||
|
|
||
| Object.entries(ctx.config.tags).map(([Key, Value]) => { | ||
| const tag = TagList.find(tag => tag.Key === Key); |
Member
There was a problem hiding this comment.
tag implicitly has any type here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the fourth one in order to resolve #70 and it will test custom configuration of our db component (setting various instance & storage arguments, setting custom password, kms key & parameter group, enabling monitoring and setting tags)