Skip to content

Comments

ci: Optimize APK output naming#206

Open
Chumor wants to merge 14 commits intoF0x1d:masterfrom
Chumor:master
Open

ci: Optimize APK output naming#206
Chumor wants to merge 14 commits intoF0x1d:masterfrom
Chumor:master

Conversation

@Chumor
Copy link
Contributor

@Chumor Chumor commented Jan 31, 2026

Overview

Refactor APK output naming to clearly distinguish between Release and CI / Staging builds.

Changes

  • Version (v) is derived from the latest Git tag.
  • Release builds: LogFox-v<versionName>-release.apk
  • CI / Staging builds: LogFox-v<versionName>-<short_commit>-release.apk

Verification

I have tested this repeatedly in my repository. The generated APKs can be downloaded from this Actions run:
LogFox Actions run

@F0x1d
Copy link
Owner

F0x1d commented Jan 31, 2026

i still dont get the actual point of these changes

@Chumor
Copy link
Contributor Author

Chumor commented Jan 31, 2026

i still dont get the actual point of these changes

Because previously only the short commit hash was used, making it hard to tell which version is newer.

@drogga
Copy link

drogga commented Feb 5, 2026

Currently there's an unnecessary v perfix appended before the numbers in the versionName in the APK's AndroidManifest, I hope this PR removes it, because the App Info shows version v, which isn't ok.

@F0x1d
Copy link
Owner

F0x1d commented Feb 5, 2026

@drogga why does it even bother u ahaha

@drogga
Copy link

drogga commented Feb 13, 2026

...because it was just wrong, but I can see you've made changes since, so thx, but to clarify - I have absolutely no issues with and don't mind (in fact no one should) if the "v" prefix is in the file names of releases and CI artifacts, it's even preferable, but it seems like both are tied for now and can't exclude only the versionName, unless this PR tackles exactly this (IDK).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants