Update version to 0.10.10 in pyproject.toml and __init__.py; improve …#49
Open
Update version to 0.10.10 in pyproject.toml and __init__.py; improve …#49
Conversation
…peak list handling in ASMReader for better robustness and add test for missing peak list scenario.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…peak list handling in ASMReader for better robustness and add test for missing peak list scenario.
Note
Low Risk
Low risk: small robustness change to ASM LC parsing plus a targeted regression test; primary behavior change is returning empty peaks instead of raising when peak lists are missing.
Overview
Bumps the library version to
0.10.10inpyproject.tomlandchromhandler/__init__.py.Improves
ASMReaderLC parsing to gracefully handle missing/variant peak list locations by checking bothmeasurement documentandanalyte aggregate documentvia safe lookups and defaulting to an empty peak list when absent.Removes temporary debug logging from
ShimadzuReaderand adds a regression test ensuring LC measurements with no peak list producechromatograms[0].peaks == [].Written by Cursor Bugbot for commit 505625a. This will update automatically on new commits. Configure here.