refactor: Improve naming of various stuffs [skip ci]#24
Merged
Conversation
AniList has both anime and manga feeds. AniListFeed only fetches from anime feeds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Break down "feeds.url" column to "feeds.platform_id", "feeds.source_id", "feeds.items_id", and "feeds.source_url". This change is done because our assumption was that we can always get request url for feed items using id contained in "feeds.url". This assumption was violated by comick.dev, which has different id for getting comic (feed source) and chapter (feed items) information.
While doing point 1, we realized some feed naming is too ambiguous. We now define:
and made modifications accordingly