You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
With the indent error write_workpackage_information is called for every workpackage run instead of just once.
With this fix I went from 96.305 to 5.682 secs for a benchmark creating 336 workpackages.
Thank you for your contribution! I hope you won't be too disappointed by the reason why we decided not to merge it:
The current indentation in the code improves JUBE's internal data persistence and is necessary for the procs attribute of the step to function correctly. We are aware of this performance penalty, but we didn't see it before publishing the release because our test suite didn't have a test that created many work packages at the time.
However, we have been working on a solution for some time:
To improve runtime performance (especially for high work package counts), data persistence and consistency, we are replacing the workpackage.xml and other files with a database. The function that is called in the line that you modified writes parts of JUBE's internal state to the aforementioned file and will be replaced by updating entries in the database. As this involves changing the core elements and principles of the JUBE code, which have not been modified for a long time, we require additional time to publish it as a beta release, which will also introduce new features.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the indent error
write_workpackage_informationis called for every workpackage run instead of just once.With this fix I went from 96.305 to 5.682 secs for a benchmark creating 336 workpackages.