fix(GH-187): moved group create button to resource groups page #196
Conversation
![korbit-ai[bot]](https://avatars.githubusercontent.com/in/322216?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review by Korbit AI
Korbit automatically attempts to detect when you fix issues in new commits.
| Category | Issue | Status |
|---|---|---|
 |
Modal Remains Open During Navigation ▹ view | ✅ Fix detected |
 |
Missing documentation for openOnCreate prop ▹ view | ✅ Fix detected |
Files scanned
| File Path | Reviewed |
|---|---|
| apps/frontend/src/components/pageHeader/index.tsx | ✅ |
| apps/frontend/src/app/resourceOverview/toolbar/toolbar.tsx | ✅ |
| apps/frontend/src/app/resources/groups/index.tsx | ✅ |
| apps/frontend/src/app/resource-groups/upsertModal/resourceGroupUpsertModal.tsx | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Check out our docs on how you can make Korbit work best for you and your team.
apps/frontend/src/app/resource-groups/upsertModal/resourceGroupUpsertModal.tsx
Outdated
Show resolved
Hide resolved
apps/frontend/src/app/resource-groups/upsertModal/resourceGroupUpsertModal.tsx
Outdated
Show resolved
Hide resolved
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
🐳 Docker images built and pushed: GitHub Container Registry: Image Digest: |
…source group upsert modal success handling
There was a problem hiding this comment.
Bug: Pagination Type Mismatch
Type inconsistency in infinite query pagination: initialPageParam is a string, pageParam is cast to a number for the queryFn, but nextPage is asserted as a string, leading to a mismatch in pagination parameter types.
libs/react-query-client/src/lib/queries/infiniteQueries.ts#L10-L21
libs/react-query-client/src/lib/queries/infiniteQueries.ts#L30-L33
libs/react-query-client/src/lib/queries/infiniteQueries.ts#L39-L42
Was this report helpful? Give feedback by reacting with 👍 or 👎
|
🐳 Docker images built and pushed: GitHub Container Registry: Image Digest: |
|
/korbit-review |
There was a problem hiding this comment.
I've completed my review and didn't find any issues... but I did find this kitten.
|\__/,| (`\
_.|o o |_ ) )
-(((---(((--------Files scanned
| File Path | Reviewed |
|---|---|
| apps/frontend/src/app/resources/usage/components/HistoryTable/index.tsx | ✅ |
| apps/frontend/src/app/user-management/index.tsx | ✅ |
| apps/frontend/src/app/unauthorized/loginForm.tsx | ✅ |
| apps/frontend/src/app/resources/groups/index.tsx | ✅ |
| libs/react-query-client/src/lib/queries/infiniteQueries.ts | ✅ |
| apps/frontend/src/app/resource-groups/upsertModal/resourceGroupUpsertModal.tsx | ✅ |
| libs/react-query-client/src/lib/requests/schemas.gen.ts | ✅ |
| libs/react-query-client/src/lib/requests/types.gen.ts | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Check out our docs on how you can make Korbit work best for you and your team.
Description by Korbit AI
What change is being made?
Move the "Add Group" button from the resource overview toolbar to the resource groups page header and update language files to reflect this UI change.
Why are these changes being made?
This change centralizes the creation of resource groups to the resource groups page, providing a more intuitive user experience by reducing toolbar clutter and focusing group management actions in their specific context. Additionally, the code has been refactored to ensure cleaner modal opening logic based on the presence of the
openOnCreateproperty.