Add trace log messages to indicate how long each loading phase takes#705
Draft
Shadowrs wants to merge 5 commits intoFabricMC:masterfrom
Draft
Add trace log messages to indicate how long each loading phase takes#705Shadowrs wants to merge 5 commits intoFabricMC:masterfrom
Shadowrs wants to merge 5 commits intoFabricMC:masterfrom
Conversation
… gatherExceptions
- the Metronome Agent which has been deprecated for years used a Mixin to inject this code into the mod loader
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is accompanied by a PR to the Fabric Mixin repo but they are still independent.
Example of log statements added:
Example output of the ported
printAuditSummaryfunction which hasn't been usable since the Metronome Agent from Sponge was unmaintained since ~2013: