Skip to content

Conversation

@varin-nair-factory
Copy link
Collaborator

@varin-nair-factory varin-nair-factory commented Jan 9, 2026

Summary

Restores P2/P3 priority levels for internal categorization while filtering review output to only post P0/P1 findings.

Changes

  • Added P2 and P3 priority level definitions back to the review prompt
  • Added explicit instruction to only post P0/P1 findings as inline comments
  • P2/P3 findings are suppressed to reduce review noise from minor issues
  • Updated output format to reflect P0/P1 only

Context

PR #13's review flagged a trivial array allocation as P1, which was too aggressive. By having P2/P3 available for categorization but filtering them from output, the droid can properly classify minor issues without cluttering the review with noise.

@varin-nair-factory varin-nair-factory self-assigned this Jan 9, 2026
@factory-droid
Copy link
Contributor

factory-droid bot commented Jan 9, 2026

Droid finished @varin-nair-factory's task —— View job


@varin-nair-factory varin-nair-factory changed the title Varin/fix review prompt 2 feat: filter review output to P0/P1 findings only Jan 9, 2026
Copy link
Contributor

@factory-droid factory-droid bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall: looks correct. This PR only updates the review prompt instructions (adds P2/P3 definitions and clarifies that only P0/P1 should be posted as inline comments), and I didn’t find any bugs introduced by the change.

@varin-nair-factory varin-nair-factory merged commit 65dab28 into main Jan 9, 2026
5 checks passed
@varin-nair-factory varin-nair-factory deleted the varin/fix-review-prompt-2 branch January 9, 2026 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants