Skip to content

Conversation

@solomon-gumball
Copy link
Contributor

Fixes -> #165

@michaelobriena
Copy link
Member

This looks pretty good.

A few questions I have:

  • Why did you remove the dependency of Plane? This seems like an unneeded duplication of that logic.
  • How much effort would it take to have a special case for border-radius of a DOM element so that we can use custom shaders to make the cutouts non-rectangular? I think this is something we have all known the limitations of but I am starting to think that we should prioritize this a lot higher.

@solomon-gumball
Copy link
Contributor Author

  1. Removed actual geometry from WebGL geometry because we are running into the same issue with browserify and require statements in the worker thread incrementing seperate counters for geometry Ids. -> DynamicGeometry renders different results in Web Workers #165
  2. Border radius is definitely something we could do, I'd imagine it'd be some custom shader logic to discard some pixels based on border-radius but we should all talk about it if it is indeed a priority.

@michaelobriena
Copy link
Member

@FarhadG @adnan-wahab Can you review?

@ghost
Copy link

ghost commented Jun 15, 2015

looks good to me.

@FarhadG
Copy link
Contributor

FarhadG commented Jun 15, 2015

Looks good!

@michaelobriena

@michaelobriena
Copy link
Member

landed as 3eae1b9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants