Skip to content

Conversation

@browles
Copy link
Contributor

@browles browles commented May 27, 2015

Fixes #160

@alexanderGugel
Copy link
Member

Can we explicitly call onSizeModeChange instead of using apply?

@michaelobriena
Copy link
Member

I think apply is pretty correct in this case.

@DnMllr
Copy link
Contributor

DnMllr commented May 28, 2015

This is the right thing to do.

@pilwon
Copy link
Contributor

pilwon commented Jun 2, 2015

@browles @alexanderGugel @michaelobriena @DnMllr

This PR seems to fix the alignment problem, but there's still an issue determining true render size of content.

For example, setting {content: 'Hello World'} produces the following result (Hello and World are split into two lines):

screen shot 2015-06-02 at 1 16 39 am

source code

@michaelobriena
Copy link
Member

@pilwon I think this solution is the correct way to handle this and the issues that you pointed out are a result of our default css we put on the body. I think we should move forward with this fix and then tackle the "Hello World" being split up after the fact.

@pilwon
Copy link
Contributor

pilwon commented Jun 10, 2015

@michaelobriena Thanks- It'd be great if the PR fixing the other part is linked from issue #160 so we could track that too.

@michaelobriena
Copy link
Member

landed as bb40181

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants