break: Rename (start|stop)Engine -> (start|stop)RenderLoop #198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Looks good to me. |
Member
|
@alexanderGugel Can we make this backwards compatibile and throw on a deprecated warning until the next minor? |
Member
Author
|
Currently it's backwards compatible, but no |
alexanderGugel
force-pushed
the
start-stop-ENGINE
branch
from
fa17bcb to
926d587
Compare
Member
Author
|
@michaelobriena Added |
alexanderGugel
force-pushed
the
start-stop-ENGINE
branch
from
926d587 to
c87c39f
Compare
Member
|
Landed as be71aae |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@michaelobriena When we renamed Engine to RenderLoop, we didn't change those method names.
I think it would be even better to completely get rid of them. I don't think one should be able to access the render loop within the worker. One
RenderLoopcan manage an arbitrary number of possibly completely unrelatedFamousEngines/ThreadManagers. Stopping the loop in one of them shouldn't affect the remaining ones IMO.I added a deprecation notice in the documentation and the commands stays the same for backwards compatibility in case someone is manually intercepting the commands.