feat: add/remove instantiated scenes from the engine #202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Member
|
lgtm 👍 |
Member
|
What is the use case for having Scenes created in space? |
Member
|
@michaelobriena Are you referring to https://github.com/Famous/engine/pull/202/files#diff-1de37d20f8b6890668f053904aaf54d8R389 ? We allow detached nodes, so I think having detached scenes makes sense. Further there might be scenarios in which the global updater itself should not be updated using FRAME commands, but should run its own rAF loop. E.g. AFAIR W3C had the discussion of allowing rAF in Workers. In general there is no use in decoupling Scene and FamousEngine if we don't account for this scenario IMO. |
Member
|
landed as e176693 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #182