feat: Node.removeUIEvent [Fixes: #95873004] #215
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dom-renderables/DOMElement.js
Outdated
Member
|
@redwoodfavorite Looks good, just some small bits |
Contributor
Author
|
Addressed your earlier comment. Good catch. |
Member
There was a problem hiding this comment.
Bikeshedding: Can we change this to this.value.UIEvents? Since we're mutating the array I think it would be better to make it obvious that we're mutating the actual array, not a clone returned by the getter. It's slightly shorter and I don't think it's less readable.
update nvm. Just saw that we're doing the same thing in addUIEvent.
Contributor
Author
|
OK @alexanderGugel I pushed that change thx for the review. |
Member
|
landed as fe2d1e6 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@alexanderGugel @DnMllr @michaelobriena