Cleanup renderers #223
Closed
Cleanup renderers #223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexanderGugel
force-pushed
the
cleanup-renderers
branch
from
523b668 to
3b22f7c
Compare
Member
|
@alexanderGugel this is very broad. Can you factor this into smaller prs? |
alexanderGugel
force-pushed
the
cleanup-renderers
branch
from
3b22f7c to
754e6ca
Compare
alexanderGugel
force-pushed
the
cleanup-renderers
branch
from
754e6ca to
9ce4972
Compare
Member
Author
|
@michaelobriena The commits mostly heavily depend on each other. It might look like a big change, but it's really not that much. The commit messages have been updated to reflect the changes. |
Member
|
This looks good. |
* Remove unused properties * Move canvas resize to WebGLRenderer (like in DOMRenderer) * Follow _-prefix convention for private properties * Instantiate DOMRenderer in _initDOMRenderer method The primary intent of those changes is to make the interface of DOMRenderer and WebGLRenderer more consistent. The above changes make it easier to make the DOMRenderer optional (similar to WebGLRenderer).
The NEED_SIZE_FOR command is no longer needed since the CONTEXT_RESIZE command is being send automatically after creating the Context.
alexanderGugel
force-pushed
the
cleanup-renderers
branch
from
9ce4972 to
9219717
Compare
Member
Author
There was a problem hiding this comment.
No longer needed.
The DOM layer will always have the same size as the Context's root element.
Member
Author
|
@michaelobriena This removed DOMRenderer#getSize (redundant). IMO this has never been exposed to the user, but should this still be marked as a breaking change? |
Member
|
@alexanderGugel Yea I would still consider it breaking. |
Member
Author
|
Ok, will change. Update: Actually the commit in question is already marked as breaking. |
Member
|
@alexanderGugel landed as e8a96d3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.