fix: No longer stopPropagation on events #227
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Because we already bubble events in our scene graph, if events bubble in the DOM too then we will have multiple copies of the same event flowing in our scene graph. This needs to be taken into consideration somehow if we want to change our stopPropagation rules. |
Member
Author
|
@DnMllr This has already been taken into account. That's why we keep track of the last event via |
alexanderGugel
force-pushed
the
remove-stopPropagation
branch
from
33fae40 to
fbe0c09
Compare
alexanderGugel
force-pushed
the
remove-stopPropagation
branch
from
fbe0c09 to
d8ee73f
Compare
Member
Author
|
Added test case. Merge please. |
Member
|
landed as 07b501d |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently screen readers have some problems with
stopPropagation.